linux-kernel - RE: [PATCH] ARM: SAMSUNG: Drop exporting s3c24xx_ts_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <01ff01cbcf4b$0e162420$2a426c60$%kim@samsung.com>
Date:	Fri, 18 Feb 2011 18:05:54 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Axel Lin' <axel.lin@...il.com>, linux-kernel@...r.kernel.org
Cc:	'Ben Dooks' <ben-linux@...ff.org>,
	'Russell King' <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Subject: RE: [PATCH] ARM: SAMSUNG: Drop exporting s3c24xx_ts_set_platdata

Axel Lin wrote:
> 
> s3c24xx_ts_set_platdata is annotated __init and not used by any module,
> thus don't export it.
> This patch fixes below warning:
> 
> WARNING: arch/arm/plat-samsung/built-in.o(__ksymtab+0x90): Section
mismatch
> in reference from the variable __ksymtab_s3c24xx_ts_set_platdata to the
> function .init.text:s3c24xx_ts_set_platdata()
> The symbol s3c24xx_ts_set_platdata is exported and annotated __init
> Fix this by removing the __init annotation of s3c24xx_ts_set_platdata or
drop
> the export.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  arch/arm/plat-samsung/dev-ts.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/dev-ts.c
b/arch/arm/plat-samsung/dev-ts.c
> index 236ef84..3e4bd81 100644
> --- a/arch/arm/plat-samsung/dev-ts.c
> +++ b/arch/arm/plat-samsung/dev-ts.c
> @@ -58,4 +58,3 @@ void __init s3c24xx_ts_set_platdata(struct
> s3c2410_ts_mach_info *pd)
> 
>  	s3c_device_ts.dev.platform_data = npd;
>  }
> -EXPORT_SYMBOL(s3c24xx_ts_set_platdata);
> --
> 1.7.2
> 
Ok, applied.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/