linux-kernel - [tip:x86/debug] x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Feb 2011 10:39:37 GMT
From:	tip-bot for Jan Beulich <JBeulich@...ell.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	jbeulich@...ell.com, JBeulich@...ell.com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:x86/debug] x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()

Commit-ID:  bb3e6251a69e67d7620373ee18e35b404964273e
Gitweb:     http://git.kernel.org/tip/bb3e6251a69e67d7620373ee18e35b404964273e
Author:     Jan Beulich <JBeulich@...ell.com>
AuthorDate: Thu, 17 Feb 2011 15:47:37 +0000
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Fri, 18 Feb 2011 08:52:29 +0100

x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()

show_regs() already prints two(!) stack traces, no need for a third one.

Signed-off-by: Jan Beulich <jbeulich@...ell.com>
LKML-Reference: <4D5D512902000078000326EE@....id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/apic/hw_nmi.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index 79fd43c..c4e557a 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -83,7 +83,6 @@ arch_trigger_all_cpu_backtrace_handler(struct notifier_block *self,
 		arch_spin_lock(&lock);
 		printk(KERN_WARNING "NMI backtrace for cpu %d\n", cpu);
 		show_regs(regs);
-		dump_stack();
 		arch_spin_unlock(&lock);
 		cpumask_clear_cpu(cpu, to_cpumask(backtrace_mask));
 		return NOTIFY_STOP;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/