linux-kernel - [tip:x86/irq] x86: Eliminate pointless adjustment attempts in fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Feb 2011 10:40:54 GMT
From:	tip-bot for Jan Beulich <JBeulich@...ell.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	ebiederm@...ssion.com, garyhade@...ibm.com, jbeulich@...ell.com,
	JBeulich@...ell.com, suresh.b.siddha@...el.com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:x86/irq] x86: Eliminate pointless adjustment attempts in fixup_irqs()

Commit-ID:  58bff947e2d164c7e5cbf7f485e4b3d4884befeb
Gitweb:     http://git.kernel.org/tip/58bff947e2d164c7e5cbf7f485e4b3d4884befeb
Author:     Jan Beulich <JBeulich@...ell.com>
AuthorDate: Thu, 17 Feb 2011 15:54:26 +0000
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Fri, 18 Feb 2011 08:58:00 +0100

x86: Eliminate pointless adjustment attempts in fixup_irqs()

Not only when an IRQ's affinity equals cpu_online_mask is there
no need to actually try to adjust the affinity, but also when
it's a subset thereof. This particularly avoids adjustment
attempts during system shutdown to any IRQs bound to CPU#0.

Signed-off-by: Jan Beulich <jbeulich@...ell.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Eric W. Biederman <ebiederm@...ssion.com>
Cc: Suresh Siddha <suresh.b.siddha@...el.com>
Cc: Gary Hade <garyhade@...ibm.com>
LKML-Reference: <4D5D52C2020000780003272C@....id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/irq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 387b6a0..78793ef 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -310,7 +310,7 @@ void fixup_irqs(void)
 		data = &desc->irq_data;
 		affinity = data->affinity;
 		if (!irq_has_action(irq) ||
-		    cpumask_equal(affinity, cpu_online_mask)) {
+		    cpumask_subset(affinity, cpu_online_mask)) {
 			raw_spin_unlock(&desc->lock);
 			continue;
 		}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/