linux-kernel - Re: [tip:x86/trampoline] x86, reboot: Move the real-mode reboot code to an assembly file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D5EAF76.6080301@linux.intel.com>
Date:	Fri, 18 Feb 2011 09:42:14 -0800
From:	"H. Peter Anvin" <hpa@...ux.intel.com>
To:	Brian Gerst <brgerst@...il.com>
CC:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	castet.matthieu@...e.fr, sfr@...b.auug.org.au, tglx@...utronix.de,
	rjw@...k.pl
Subject: Re: [tip:x86/trampoline] x86, reboot: Move the real-mode reboot code
 to an assembly file

On 02/18/2011 04:31 AM, Brian Gerst wrote:
>> +
>> +       /* Patch post-real-mode segment jump */
>> +       movw    dispatch_table(%ebx,%ecx,2),%cx
>> +       movw    %cx, 101f(%ebx)
>> +       movw    %ax, 102f(%ebx)
> 
> This looks wrong.  The type parameter is in %eax, not %ecx, and this
> code is expecting %eax to be a segment.
> 

You're quite right.  I decided to make a change, changed all the
invocations, and forgot to change the actual code.  D'oh!

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/