linux-kernel - Re: [PATCH] Reduce uidhash lock hold time when lookup succeeds

Open Source and information security mailing list archives

Message-ID: <20110218182502.GA22238@localhost>
Date:	Fri, 18 Feb 2011 12:25:02 -0600
From:	"Serge E. Hallyn" <serge.hallyn@...onical.com>
To:	Matt Helsley <matthltc@...ibm.com>
Cc:	linux-kernel@...r.kernel.org,
	Pavel Emelyanov <xemul@...allels.com>,
	containers@...ts.linux-foundation.org,
	David Howells <dhowells@...hat.com>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH] Reduce uidhash lock hold time when lookup succeeds

Quoting Matt Helsley (matthltc@...ibm.com):
> When lookup succeeds we don't need the "new" user struct which hasn't
> been linked into the uidhash. So we can immediately drop the lock and
> then free "new" rather than free it with the lock held.
> 
> Signed-off-by: Matt Helsley <matthltc@...ibm.com>
> Cc: David Howells <dhowells@...hat.com>
> Cc: Pavel Emelyanov <xemul@...allels.com>
> Cc: Alexey Dobriyan <adobriyan@...il.com>
> Cc: "Serge E. Hallyn" <serge@...lyn.com>

Acked-by: Serge E. Hallyn <serge@...lyn.com>

And might I say that the label 'out_unlock' in that function is
sadly named :)

> Cc: containers@...ts.linux-foundation.org
> ---
>  kernel/user.c |   12 +++++++-----
>  1 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/user.c b/kernel/user.c
> index 5c598ca..4ea8e58 100644
> --- a/kernel/user.c
> +++ b/kernel/user.c
> @@ -157,16 +157,18 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid)
>  		 */
>  		spin_lock_irq(&uidhash_lock);
>  		up = uid_hash_find(uid, hashent);
> -		if (up) {
> +		if (!up) {
> +			uid_hash_insert(new, hashent);
> +			up = new;
> +		}
> +		spin_unlock_irq(&uidhash_lock);
> +
> +		if (up != new) {
>  			put_user_ns(ns);
>  			key_put(new->uid_keyring);
>  			key_put(new->session_keyring);
>  			kmem_cache_free(uid_cachep, new);
> -		} else {
> -			uid_hash_insert(new, hashent);
> -			up = new;
>  		}
> -		spin_unlock_irq(&uidhash_lock);
>  	}
>  
>  	return up;
> -- 
> 1.6.3.3
> 
> _______________________________________________
> Containers mailing list
> Containers@...ts.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives