linux-kernel - Re: [PATCH] Input: serio: Compile error fix (altera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 19 Feb 2011 13:45:49 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Dustan Bower <dustan.bower@...il.com>,
	Grant Likely <grant.likely@...retlab.ca>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Thomas Chou <thomas@...ron.com.tw>
Subject: Re: [PATCH] Input: serio: Compile error fix (altera_ps2.c)

On Sat, Feb 19, 2011 at 03:04:19PM -0500, Dustan Bower wrote:
> Fixed compile error, today's linux-next tree:
> 
>   CC [M]  drivers/input/serio/altera_ps2.o
> drivers/input/serio/altera_ps2.c:182:1: error: expected ‘,’ or ‘;’ before ‘extern’
> make[1]: *** [drivers/input/serio/altera_ps2.o] Error 1
> make: *** [_module_drivers/input/serio] Error 2
> 
> Signed-off-by: Dustan Bower <dustan.bower@...il.com>

Thanks Dustan.

Grant, maybe you could amend the original patch so that we do not
introduce bisection failure point?

> ---
>  drivers/input/serio/altera_ps2.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
> index 3fee88b..d363dc4 100644
> --- a/drivers/input/serio/altera_ps2.c
> +++ b/drivers/input/serio/altera_ps2.c
> @@ -178,7 +178,7 @@ static int __devexit altera_ps2_remove(struct platform_device *pdev)
>  static const struct of_device_id altera_ps2_match[] = {
>  	{ .compatible = "ALTR,ps2-1.0", },
>  	{},
> -}
> +};
>  MODULE_DEVICE_TABLE(of, altera_ps2_match);
>  #else /* CONFIG_OF */
>  #define altera_ps2_match NULL
> -- 
> 1.7.4.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/