linux-kernel - Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1298217622.7179.93.camel@Joe-Laptop>
Date:	Sun, 20 Feb 2011 08:00:22 -0800
From:	Joe Perches <joe@...ches.com>
To:	Harry Wei <jiaweiwei.xiyou@...il.com>
Cc:	davem@...emloft.net, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, greg@...ah.com, rdunlap@...otime.net,
	pavel@....cz
Subject: Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses

On Sun, 2011-02-20 at 21:59 +0800, Harry Wei wrote:
> On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> > Add quotes around email address with periods and commas.
> Hmm, what about some other conditions except 
> for periods and commas in maintainers' M:. 
> Like following:
> 1> Character '-' in M:

Dashes are not an issue.

> 2> No name of the M:
> M:      support@....com  

Names and angle brackets are optional.

> 3> Messy code in M:
> M:      Benoît Cousson <b-cousson@...com>

8 bit characters _might_ be an issue, but
no one has reported any problems yet.

I think you should read and understand rfc 2822
before continuing with this.

Utilities like git send-email and get_maintainer.pl
generally provide email address parsing for only a
subset of all valid address styles.

As these utilities are done mostly by regex, not
all valid email addresses are supported because the
regex validations get ridiculously complicated.

There are some "monster" regex classes that attempt
to support a greater range of valid email address
styles, but the pain of implementation generally
isn't worth it.

You're free to try to improve it of course, but I
think that modifications to the address styles
currently used in MAINTAINERS to remove "special"
address style handling isn't necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/