linux-kernel - Re: [PATCH] staging/et131x: fix et131x_rx_dma_disable halt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110220191307.07faacda@lxorguk.ukuu.org.uk>
Date:	Sun, 20 Feb 2011 19:13:07 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging/et131x: fix et131x_rx_dma_disable halt_status
 usage

On Sun, 20 Feb 2011 20:03:34 +0100
Marcin Slusarz <marcin.slusarz@...il.com> wrote:

> Commit 1bd751c1abc1029e8a0ae63ef4f19357c735a2a3
> ("Staging: et131x: Clean up rxdma_csr") changed csr from bitfield to
> u32, but failed to convert 2 uses of halt_status bit. It did:
> 
> - if (csr.bits.halt_status != 1)
> + if ((csr & 0x00020000) != 1)
> 
> which is wrong, because second version is always true.
> Fix it.
> 
> This bug was found by coccinelle (http://coccinelle.lip6.fr/).
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Cc: Alan Cox <alan@...ux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>

Acked-by: Alan Cox <alan@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/