linux-kernel - Re: [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1102191745180.27722@chino.kir.corp.google.com>
Date:	Sat, 19 Feb 2011 17:51:31 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Li Zefan <lizf@...fujitsu.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Paul Menage <menage@...gle.com>, miaox@...fujitsu.com,
	linux-mm@...ck.org
Subject: Re: [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK_ALLOC()

On Thu, 17 Feb 2011, Li Zefan wrote:

> Those functions that use NODEMASK_ALLOC() can't propogate errno
> to users, but will fail silently.
> 
> Since all of them are called with cgroup_mutex held, here we use
> a global nodemask_t variable.
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

I like the idea and the comment is explicit enough that we don't need any 
refcounting to ensure double usage under cgroup_lock.  I think each 
function should be modified to use cpuset_mems directly, though, instead 
of defining local variables that indirectly access it which only serves to 
make this patch smaller.  Then we can ensure that all occurrences of 
cpuset_mems appear within the lock without being concerned about other 
references.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/