[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <b691a7be970d6aafcd12ccc32ba812ce39fcf027.1298214672.git.minchan.kim@gmail.com>
Date: Mon, 21 Feb 2011 00:17:17 +0900
From: Minchan Kim <minchan.kim@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-mm <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>,
Johannes Weiner <hannes@...xchg.org>,
Balbir Singh <balbir@...ux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
Minchan Kim <minchan.kim@...il.com>
Subject: [PATCH v2 1/2] memcg: remove unnecessary BUG_ON
Now memcg in unmap_and_move checks BUG_ON of charge.
But mem_cgroup_prepare_migration returns either 0 or -ENOMEM.
If it returns -ENOMEM, it jumps out unlock without the check.
If it returns 0, it can pass BUG_ON. So it's meaningless.
Let's remove it.
Cc: Johannes Weiner <hannes@...xchg.org>
Cc: Balbir Singh <balbir@...ux.vnet.ibm.com>
Acked-by: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Signed-off-by: Minchan Kim <minchan.kim@...il.com>
---
mm/migrate.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index eb083a6..2abc9c9 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -683,7 +683,6 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private,
rc = -ENOMEM;
goto unlock;
}
- BUG_ON(charge);
if (PageWriteback(page)) {
if (!force || !sync)
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists