linux-kernel - Re: [tip:x86/mm] x86-64, NUMA: Restructure initmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110221083511.GC31267@htj.dyndns.org>
Date:	Mon, 21 Feb 2011 09:35:11 +0100
From:	Tejun Heo <tj@...nel.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	tglx@...utronix.de, yinghai@...nel.org, brgerst@...il.com,
	gorcunov@...il.com, shaohui.zheng@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [tip:x86/mm] x86-64, NUMA: Restructure initmem_init()

On Sat, Feb 19, 2011 at 07:34:57PM -0800, David Rientjes wrote:
> This doesn't look very clean, I think it would be much better to extract 
> the iteration out to a function of its own which takes an init and scan 
> function as arguments and then deal only with numa_off, CONFIG_ACPI_NUMA, 
> and CONFIG_AMD_NUMA callers in initmem_init().  If that's done, it's clear 
> that the dummy implementation will never fail and so the BUG() in this 
> case is never possible (which is intended if all else fails).

I don't know.  Maybe.  Care to send a patch?

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/