linux-kernel - Re: [PATCH] Fix over-zealous flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49hbbx18pq.fsf@segfault.boston.devel.redhat.com>
Date:	Mon, 21 Feb 2011 14:36:01 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	NeilBrown <neilb@...e.de>
Cc:	Andrew Patterson <andrew.patterson@...com>,
	Jens Axboe <axboe@...nel.dk>, linux-raid@...r.kernel.org,
	dm-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix over-zealous flush_disk when changing device size.

NeilBrown <neilb@...e.de> writes:

> -int __invalidate_device(struct block_device *bdev)
> +int __invalidate_device2(struct block_device *bdev, bool kill_dirty)
>  {
>  	struct super_block *sb = get_super(bdev);
>  	int res = 0;
> @@ -1614,7 +1614,7 @@ int __invalidate_device(struct block_device *bdev)
>  		 * hold).
>  		 */
>  		shrink_dcache_sb(sb);
> -		res = invalidate_inodes(sb);
> +		res = invalidate_inodes(sb, kill_dirty);
>  		drop_super(sb);
>  	}
>  	invalidate_bdev(bdev);

Neil, I think you also need to change the EXPORT_SYMBOL from
__invalidate_device to __invalidate_device2.  The floppy module won't
build without that change.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/