linux-kernel - Re: [PATCH] gpio: Fix wrong pointer type in pca953x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110222123601.GA1966@bicker>
Date:	Tue, 22 Feb 2011 15:36:01 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Dirk Eibach <eibach@...ys.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: Fix wrong pointer type in pca953x

On Tue, Feb 22, 2011 at 09:56:50AM +0100, Dirk Eibach wrote:
>  	struct pca953x_platform_data *pdata;
>  	struct device_node *node;
> -	const uint16_t *val;
> +	const u32 *val;
>  

This should probably be signed?  We compare it against zero later on.

                if (*val < 0)
                        dev_warn(&client->dev,
                                 "invalid gpio-base in device tree\n");

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/