linux-kernel - Re: [PATCH v2 12/13] da850: pruss SUART platform specific additions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01ADA340BA2E4A62BBFC1E4FB630B380@subhasishg>
Date:	Tue, 22 Feb 2011 18:54:18 +0530
From:	"Subhasish Ghosh" <subhasish@...tralsolutions.com>
To:	"Sergei Shtylyov" <sshtylyov@...sta.com>
Cc:	<davinci-linux-open-source@...ux.davincidsp.com>,
	<sachi@...tralsolutions.com>,
	"Russell King" <linux@....linux.org.uk>,
	"Kevin Hilman" <khilman@...prootsystems.com>, <nsekhar@...com>,
	"open list" <linux-kernel@...r.kernel.org>, <m-watkins@...com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 12/13] da850: pruss SUART platform specific additions.

Ok, will do.

--------------------------------------------------
From: "Sergei Shtylyov" <sshtylyov@...sta.com>
Sent: Tuesday, February 22, 2011 4:50 PM
To: "Subhasish Ghosh" <subhasish@...tralsolutions.com>
Cc: <davinci-linux-open-source@...ux.davincidsp.com>; 
<sachi@...tralsolutions.com>; "Russell King" <linux@....linux.org.uk>; 
"Kevin Hilman" <khilman@...prootsystems.com>; <nsekhar@...com>; "open list" 
<linux-kernel@...r.kernel.org>; <m-watkins@...com>; 
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 12/13] da850: pruss SUART platform specific 
additions.

> Hello.
>
> On 22-02-2011 12:18, Subhasish Ghosh wrote:
>
>> I could not follow your recommendations clearly, are you suggesting this:
>
>> int __init da8xx_register_pruss(struct da8xx_pruss_devices *pruss_device)
>> {
>> #ifdef CONFIG_SERIAL_PRUSS_SUART_MODULE
>> int ret;
>>
>> ret = clk_add_alias(NULL, "da8xx_pruss_uart.1",
>> NULL, &da850_mcasp_device.dev);
>> if (ret < 0)
>> return ret;
>> #endif
>> da8xx_pruss_dev.dev.platform_data = pruss_device;
>> return platform_device_register(&da8xx_pruss_dev);
>> }
>
>    Yes. But still better would be to wrap clk_add_alias() into a function 
> of its own (defining it empty if CONFIG_SERIAL_PRUSS_SUART_MODULE is not 
> defined).
>
> WBR, Sergei 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/