lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110222133529.56b02ebb.randy.dunlap@oracle.com>
Date:	Tue, 22 Feb 2011 13:35:29 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Grant Likely <grant.likely@...retlab.ca>,
	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: [PATCH] spi/spi_oc_tiny and spi_altera.c: fix build errors

On Tue, 22 Feb 2011 13:24:38 -0800 Andres Salomon wrote:

> Fix the following build error due to a missing semicolon:
> 
>  CC [M]  drivers/spi/spi_oc_tiny.o
> drivers/spi/spi_oc_tiny.c:394: error: expected ‘,’ or ‘;’ before ‘extern’
> make[2]: *** [drivers/spi/spi_oc_tiny.o] Error 1
> 
> Signed-off-by: Andres Salomon <dilinger@...ued.net>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Same fix is needed for drivers/spi/spi_altera.c.
I already had this patch ready to send.  Grant, can you extract
the spi_altera.c patch...?


---
From: Randy Dunlap <randy.dunlap@...cle.com>

Fix build error due to missing semi-colon:

drivers/spi/spi_altera.c:308: error: expected ',' or ';' before 'extern'
drivers/spi/spi_oc_tiny.c:394: error: expected ',' or ';' before 'extern'

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 drivers/spi/spi_altera.c  |    2 +-
 drivers/spi/spi_oc_tiny.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20110222.orig/drivers/spi/spi_oc_tiny.c
+++ linux-next-20110222/drivers/spi/spi_oc_tiny.c
@@ -390,7 +390,7 @@ static int __devexit tiny_spi_remove(str
 static const struct of_device_id tiny_spi_match[] = {
 	{ .compatible = "opencores,tiny-spi-rtlsvn2", },
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, tiny_spi_match);
 #else /* CONFIG_OF */
 #define tiny_spi_match NULL
--- linux-next-20110222.orig/drivers/spi/spi_altera.c
+++ linux-next-20110222/drivers/spi/spi_altera.c
@@ -304,7 +304,7 @@ static int __devexit altera_spi_remove(s
 static const struct of_device_id altera_spi_match[] = {
 	{ .compatible = "ALTR,spi-1.0", },
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, altera_spi_match);
 #else /* CONFIG_OF */
 #define altera_spi_match NULL

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ