linux-kernel - Re: [PATCH 10/11] mm: Move contig_page_data define to bootmem.c/nobootmem.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110222154806.0be18267.akpm@linux-foundation.org>
Date:	Tue, 22 Feb 2011 15:48:06 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	David Miller <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/11] mm: Move contig_page_data define to
 bootmem.c/nobootmem.c

On Mon,  7 Feb 2011 15:17:11 -0800
Yinghai Lu <yinghai@...nel.org> wrote:

> We can remove #ifdef in mm/page_alloc.c
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> ---
>  mm/bootmem.c    |    7 +++++++
>  mm/nobootmem.c  |    5 +++++
>  mm/page_alloc.c |    9 ---------
>  3 files changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/mm/bootmem.c b/mm/bootmem.c
> index 4403e2f..79d9c3c 100644
> --- a/mm/bootmem.c
> +++ b/mm/bootmem.c
> @@ -23,6 +23,13 @@
>  
>  #include "internal.h"
>  
> +#ifndef CONFIG_NEED_MULTIPLE_NODES
> +struct pglist_data __refdata contig_page_data = {
> + .bdata = &bootmem_node_data[0]
> + };
> +EXPORT_SYMBOL(contig_page_data);
> +#endif

Please fix the layout when moving this code - it's quite busted and as
we're touching the code anyway, we might as well fix it up.

Patches 9, 10 and 11 look good to me and won't conflict with ther
pending work - please merge them up via the appropriate ingotree.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/