linux-kernel - Re: [PATCH 5/7] ARM: tegra: timer: Enable timer and rtc clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTim=TZaqZFSJwOAN2gntvu=fiHVPQVn12=WyF9Wi@mail.gmail.com>
Date:	Mon, 21 Feb 2011 21:32:11 -0800
From:	Olof Johansson <olof@...om.net>
To:	Colin Cross <ccross@...roid.com>
Cc:	linux-tegra@...r.kernel.org, konkers@...roid.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	mike@...pulab.co.il, Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH 5/7] ARM: tegra: timer: Enable timer and rtc clocks

Hi,


On Mon, Feb 21, 2011 at 6:39 PM, Colin Cross <ccross@...roid.com> wrote:
> Enable the timer and rtc clocks to prevent them being
> turned off by the bootloader clock disabling code.
>
> Signed-off-by: Colin Cross <ccross@...roid.com>
> ---
>  arch/arm/mach-tegra/timer.c |   14 ++++++++++++--
>  1 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/timer.c b/arch/arm/mach-tegra/timer.c
> index ffa6a68..31b4f56 100644
> --- a/arch/arm/mach-tegra/timer.c
> +++ b/arch/arm/mach-tegra/timer.c
> @@ -18,6 +18,7 @@
>  */
>
>  #include <linux/init.h>
> +#include <linux/err.h>
>  #include <linux/sched.h>
>  #include <linux/time.h>
>  #include <linux/interrupt.h>
> @@ -193,9 +194,20 @@ static struct irqaction tegra_timer_irq = {
>
>  static void __init tegra_init_timer(void)
>  {
> +       struct clk *clk;
>        unsigned long rate = clk_measure_input_freq();
>        int ret;
>
> +       clk = clk_get_sys("timer", NULL);
> +       BUG_ON(IS_ERR(clk));
> +       clk_enable(clk);
> +       clk_put(clk);
> +
> +       clk = clk_get_sys("rtc-tegra", NULL);
> +       BUG_ON(IS_ERR(clk));
> +       clk_enable(clk);
> +       clk_put(clk);

Why initialize the rtc clock here? Not all boards use it and instead
use the rtc on the pmic. Seems wasteful to clock it unless the driver
for it is probed and configured.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/