linux-kernel - Re: [PATCH] msm: add single-wire serial bus interface (SSBI) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1298421567.17118.8.camel@m0nster>
Date:	Tue, 22 Feb 2011 16:39:27 -0800
From:	Daniel Walker <dwalker@...o99.com>
To:	David Brown <davidb@...eaurora.org>
Cc:	Dima Zavin <dima@...roid.com>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Kenneth Heitke <kheitke@...eaurora.org>,
	Pavel Machek <pavel@....cz>, tsoni@...eaurora.org,
	linux-arm-msm@...r.kernel.org,
	ARM PORT <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] msm: add single-wire serial bus interface (SSBI) driver

On Tue, 2011-02-22 at 16:17 -0800, David Brown wrote:
> On Tue, Feb 22 2011, Daniel Walker wrote:
> 
> > On Tue, 2011-02-22 at 12:47 -0800, Dima Zavin wrote:
> >
> >> What is the problem leaving it under arch/arm/mach-msm?
> >
> > Because it's a driver.
> 
> There are a lot of other drivers currently under various arch
> subsystems.  I'm not sure if a driver that is specific to only one arch
> has a strong reason to be elsewhere in the kernel.  If there was a
> possibility of there being other devices that used SSBI, it might make
> sense to put it elsewhere.  But, as far as I know, this device is only
> found on MSM chips.

There are lots of arch specific drivers under drivers/ . In fact I'm
sure there are more arch specific drivers under drivers/ than anyplace
else. That's how we organize things in Linux.

> It seems kind of unusual to create an entirely new directory under
> drivers to hold what will only ever be a single driver.

Then put it under another directory.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/