linux-kernel - Re: [PATCH 2/2] Staging: vme: fix potential infinite loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110223092424.GA5195@athena>
Date:	Wed, 23 Feb 2011 10:24:24 +0100
From:	Manohar Vanga <manohar.vanga@...n.ch>
To:	<martyn.welch@...com>
CC:	<cota@...ap.org>, <devel@...verdev.osuosl.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Staging: vme: fix potential infinite loop

On Tue, Feb 22, 2011 at 08:36:16PM +0100, Manohar Vanga wrote:
> Fix a bug in vme_register_bridge that resulted in an infinite loop if
> device_register failed.
> 
> Signed-off-by: Manohar Vanga <manohar.vanga@...n.ch>
> ---
>  drivers/staging/vme/vme.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index 88bf455..7eb4568 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -1364,9 +1364,14 @@ int vme_register_bridge(struct vme_bridge *bridge)
>  	return retval;
>  
>  err_reg:
> +	/*
> +	 * Ignore the failed driver and unregister the rest
> +	 */
> +	i--

Ugh. Missing semicolon here. I'll resend the corrected patch.

Thanks,
Manohar Vanga
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/