linux-kernel - Re: [PATCH 1/2] Staging: vme: remove unreachable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D652574.8040206@ge.com>
Date:	Wed, 23 Feb 2011 15:19:16 +0000
From:	Martyn Welch <martyn.welch@...com>
To:	Manohar Vanga <manohar.vanga@...n.ch>
CC:	Dan Carpenter <error27@...il.com>, devel@...verdev.osuosl.org,
	cota@...ap.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Staging: vme: remove unreachable code

On 23/02/11 15:16, Manohar Vanga wrote:
>>> There are two problems with this loop.  1) It unregisters the device
>>> which failed to register.  2) It is a forever loop.
>>>
>>
>> Even if "i" is a signed int?
> 
> The infinite loop is because "i" is not decremented anywhere in the loop. Not
> because of signedness.
> 

Ah, yeah, that would help.

Martyn

> Thanks,
> Manohar Vanga


-- 
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms                   | Wales (3828642) at 100
T +44(0)127322748                          | Barbirolli Square, Manchester,
E martyn.welch@...com                      | M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/