linux-kernel - Re: [PATCH 5/7] ARM: tegra: timer: Enable timer and rtc clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTikiLwofnVB=f54MdqjAmrT2EvSxRryw3J7Jd5oC@mail.gmail.com>
Date:	Wed, 23 Feb 2011 09:39:27 -0800
From:	Colin Cross <ccross@...roid.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	linux-tegra@...r.kernel.org, konkers@...roid.com,
	mike@...pulab.co.il, linux-kernel@...r.kernel.org, olof@...om.net,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 5/7] ARM: tegra: timer: Enable timer and rtc clocks

On Tue, Feb 22, 2011 at 12:56 PM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Mon, Feb 21, 2011 at 06:39:50PM -0800, Colin Cross wrote:
>> +     struct clk *clk;
>>       unsigned long rate = clk_measure_input_freq();
>>       int ret;
>>
>> +     clk = clk_get_sys("timer", NULL);
>> +     BUG_ON(IS_ERR(clk));
>> +     clk_enable(clk);
>> +     clk_put(clk);
>> +
>> +     clk = clk_get_sys("rtc-tegra", NULL);
>> +     BUG_ON(IS_ERR(clk));
>> +     clk_enable(clk);
>> +     clk_put(clk);
>
> It's probably better to leave them get'd if you're continuing to use
> them and just forget the reference.
>

Good point, fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/