linux-kernel - Re: [PATCH v3 1/2] PRUSS UIO driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1102232153500.2701@localhost6.localdomain6>
Date:	Wed, 23 Feb 2011 21:54:19 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
cc:	Pratheesh Gangadhar <pratheesh@...com>,
	davinci-linux-open-source@...ux.davincidsp.com,
	amit.chatterjee@...com, gregkh@...e.de,
	linux-kernel@...r.kernel.org, hjk@...sjkoch.de,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/2] PRUSS UIO driver support

On Wed, 23 Feb 2011, Sergei Shtylyov wrote:
> Hello.
> 
> On 23-02-2011 23:25, Thomas Gleixner wrote:
> 
> > > +	prussio_virt_addr =
> > > +	    ioremap(regs_prussio->start,
> > > +		    regs_prussio->end - regs_prussio->start + 1);
> 
> > Either make those variable names shorter or do:
> 
> >         len = regs_prussio->end - regs_prussio->start + 1;
> 
>    Or even:
> 
> 	len = resource_size(regs_prussio);
> 
> >         prussio_virt_addr = ioremap(regs_prussio->start, len);

Good point. Forgot about that one :)

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/