linux-kernel - Re: [Stable-review] [28/70] staging: brcm80211: bugfix for softmac crash on multi cpu configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1298427787.2211.498.camel@localhost>
Date:	Wed, 23 Feb 2011 02:23:07 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	Roland Vossen <rvossen@...adcom.com>,
	Brett Rudley <brudley@...adcom.com>,
	Arend van Spriel <arend@...adcom.com>,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	stable-review@...nel.org, alan@...rguk.ukuu.org.uk
Subject: Re: [Stable-review] [28/70] staging: brcm80211: bugfix for softmac
 crash on multi cpu configurations

On Tue, 2011-02-22 at 14:17 -0800, Greg KH wrote:
> 2.6.37-stable review patch.  If anyone has any objections, please let us know.
> 
> ------------------
> 
> From: Roland Vossen <rvossen@...adcom.com>
> 
> commit 6a3be6e6e7feb4cb35275475d6a863b748d59cc3 upstream.

The upstream commit looks completely different; the diffstat is:

 drivers/staging/brcm80211/sys/wl_mac80211.c  |   12 ++++++++++--
 drivers/staging/brcm80211/sys/wlc_mac80211.c |   13 +++++++++++++
 drivers/staging/brcm80211/sys/wlc_pub.h      |    2 ++
 3 files changed, 25 insertions(+), 2 deletions(-)

Why is this so different?

Ben.

[...]
>  drivers/staging/brcm80211/sys/wlc_mac80211.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
> +++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
> @@ -5336,7 +5336,6 @@ wlc_sendpkt_mac80211(wlc_info_t *wlc, vo
>  	fifo = prio2fifo[prio];
>  
>  	ASSERT((uint) PKTHEADROOM(sdu) >= TXOFF);
> -	ASSERT(!PKTSHARED(sdu));
>  	ASSERT(!PKTNEXT(sdu));
>  	ASSERT(!PKTLINK(sdu));
>  	ASSERT(fifo < NFIFO);

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)