linux-kernel - Re: [PATCH v5] EHCI bus glue for on-chip PMC MSP USB controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110224110138.GA28665@bicker>
Date:	Thu, 24 Feb 2011 14:28:19 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Anoop P A <anoop.pa@...il.com>
Cc:	"gregkh @ suse . de" <gregkh@...e.de>,
	"dbrownell @ users . sourceforge . net" 
	<dbrownell@...rs.sourceforge.net>,
	"stern @ rowland . harvard . edu" <stern@...land.harvard.edu>,
	"pkondeti @ codeaurora . org" <pkondeti@...eaurora.org>,
	"jacob . jun . pan @ intel . com" <jacob.jun.pan@...el.com>,
	"linux-usb @ vger . kernel . org" <linux-usb@...r.kernel.org>,
	"alek . du @ intel . com" <alek.du@...el.com>,
	"linux-kernel @ vger . kernel . org" <linux-kernel@...r.kernel.org>,
	"gadiyar @ ti . com" <gadiyar@...com>,
	"ralf @ linux-mips . org" <ralf@...ux-mips.org>,
	"linux-mips @ linux-mips . org" <linux-mips@...ux-mips.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH v5] EHCI bus glue for on-chip PMC MSP USB controller

On Thu, Feb 24, 2011 at 03:49:15PM +0530, Anoop P A wrote:
> > Also this is dead code.  No one will complain, if you just delete it.
> You mean entire ehci_msp_suspend() ??
> 

Sure why not?  It's not really ready to submit.  People can't complain
about it if you don't submit it.

(Understand that I'm from the peanut gallery.  I'm not in anyway a 
maintainer of this code and my suggestions carry very little weight).

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/