[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <AANLkTik8B0c0Bfv2O2-vcNUGGitywRjUXrGE44kP1cq4@mail.gmail.com>
Date: Thu, 24 Feb 2011 13:35:46 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Chuanxiao Dong <chuanxiao.dong@...el.com>
Cc: linux-mmc@...r.kernel.org, cjb@...top.org, adrian.hunter@...ia.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1]mmc: fix division by zero when calculate mmc erase time
2011/2/24 Chuanxiao Dong <chuanxiao.dong@...el.com>:
> Since if clock gating feature is enabled, the clock frequency may be zero when
> host clock is gated. In such scenario, mmc_set_mmc_erase_timeout() may have a
> division by zero bug.
>
> So this patch used mmc_host_clk_rate() to fix this.
>
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@...el.com>
Acked-by: Linus Walleij <linus.walleij@...aro.org>
Actually I think these divide-by zero bugs were there before since clock
0 is perfectly legal, we just didn't trigger them before.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists