linux-kernel - Re: [PATCH 1/2] staging: remove null checks before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Feb 2011 09:06:19 -0800
From:	Greg KH <gregkh@...e.de>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Ilia Mirkin <imirkin@...m.mit.edu>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: remove null checks before kfree

On Thu, Feb 24, 2011 at 11:08:29AM -0500, Steven Rostedt wrote:
> On Tue, Feb 22, 2011 at 03:53:40AM -0500, Ilia Mirkin wrote:
> > This patch was created with the following semantic patch:
> > 
> > // <smpl>
> > @@
> > expression E;
> > @@
> > 
> > - if (E != NULL) kfree(E);
> > + kfree(E);
> > // </smpl>
> 
> OK, so when will we be removing the unlikely() from the implementations
> of kfree()?
> 
> 	if (unlikely(ZERO_OR_NULL_PTR(block)))
> 			return;

Have you run the tool that checks for unlikely being true here?  Odds
are, even with all of these changes, the large majority of the time
kfree is called, it has a valid pointer.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/