linux-kernel - Re: [PATCH] Network driver for PMC-Sierra MSP71xx TSMAC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110224094556.6c371c38@nehalam>
Date:	Thu, 24 Feb 2011 09:45:56 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	"Anoop P.A" <anoop.pa@...il.com>
Cc:	davem@...emloft.net, khilman@...prootsystems.com, cyril@...com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mips@...ux-mips.org
Subject: Re: [PATCH] Network driver for PMC-Sierra MSP71xx TSMAC.

On Thu, 24 Feb 2011 17:27:40 +0530
"Anoop P.A" <anoop.pa@...il.com> wrote:

> +#if PMC_MSP_TSMAC
> +
> +config DESC_ALL_DSPRAM
> +	bool "TX/RX Descriptors in DSPRAM"
> +	depends on DMA_TO_SPRAM
> +	default n
> +	help
> +	  Turning this on puts TX/RX descriptors in DSPRAM. Otherwise they are in
> +	  DRAM.
> +
> +config TSMAC_LINELOOPBACK_FEATURE
> +	bool "lineLoopBack command"
> +	default n
> +	help
> +	  Turning this on includes the lineLoopBack command in the driver's proc
> +	  interface.  Echoing 1 into the lineLoopBack results in all rx packets
> +	  being transmitted out the same port.
> +
> +config TSMAC_TEST_CMDS
> +	bool "test commands"
> +	default n
> +	help
> +	  Turning this on includes the testing commands in the driver's proc
> +	  interface.  These are used internally by PMC.
> +

Too many config options. Usually no config options is best, or at
most one debug option.

The proc interface for testing should be replaced with debugfs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/