linux-kernel - Re: [024/115] USB: prevent buggy hubs from crashing the USB stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110224181614.GA10547@suse.de>
Date:	Thu, 24 Feb 2011 10:16:14 -0800
From:	Greg KH <gregkh@...e.de>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Felipe Balbi <balbi@...com>,
	Alexander Holler <holler@...oftware.de>,
	Michael Jones <michael.jones@...rix-vision.de>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	stable@...nel.org, stable-review@...nel.org,
	torvalds@...ux-foundation.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	USB list <linux-usb@...r.kernel.org>,
	linux-omap@...r.kernel.org
Subject: Re: [024/115] USB: prevent buggy hubs from crashing the USB stack

On Thu, Feb 24, 2011 at 10:12:46AM -0800, Greg KH wrote:
> On Thu, Feb 24, 2011 at 12:57:20PM -0500, Alan Stern wrote:
> > On Thu, 24 Feb 2011, Felipe Balbi wrote:
> > 
> > > On Thu, Feb 24, 2011 at 09:18:14AM -0800, Greg KH wrote:
> > > > On Thu, Feb 24, 2011 at 11:16:38AM +0200, Felipe Balbi wrote:
> > > > > Hi,
> > > > > 
> > > > > On Thu, Feb 24, 2011 at 10:15:23AM +0100, Alexander Holler wrote:
> > > > > > >On Wed, Feb 23, 2011 at 10:26:20AM -0500, Alan Stern wrote:
> > > > > > >>In both cases, it appears that the problem is caused by the fact that
> > > > > > >>the musb host-controller driver doesn't set the hcd->has_tt flag.
> > > > > > >>
> > > > > > >>Felipe, you should know where it belongs.  It should be easy enough to
> > > > > > >>add.
> > > > > > >
> > > > > > >Sure Alan, it's attached to this mail. Compile tested only though.
> > > > > > >Michael, would you care to give your tested-by ?
> > > > > > 
> > > > > > I can do, I'm using exactly the same patch since yesterday. ;)
> > > > > > 
> > > > > > Tested-by: Alexander Holler <holler@...oftware.de>
> > > > > 
> > > > > Thanks a lot Alex, Greg, can you still take this to -rc ? Do you need a
> > > > > pull request or you can take this one patch ?
> > > > 
> > > > Wait, where does this need to go?  For the final 2.6.38 release and then
> > > > also for .37-stable?
> > > > 
> > > > Or just .37-stable?
> > > > 
> > > > confused.
> > > > 
> > > > And no, I don't need a pull request, I can handle one patch through
> > > > email :)
> > > 
> > > final .38 and .37-stable :-) Thanks Greg :-)
> > 
> > It's important that this patch appear in .37-stable at the same time as
> > the $SUBJECT patch.  If that means delaying $SUBJECT for one release, 
> > so be it -- it was not a very important change.
> 
> Ok, I'll drop this from the next .37-stable release until this happens.

Oops, wait, that's going to be hard as it's already in 2.6.37.1.

Oh, I guess I can revert it for the .2 release in a few hours, and then
add it back in for .3...

I'll go do that.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/