linux-kernel - Re: [RFC PATCH] ipmi: convert OF driver to platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201102241534.50886.arnd@arndb.de>
Date:	Thu, 24 Feb 2011 15:34:50 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	devicetree-discuss@...ts.ozlabs.org
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <robherring2@...il.com>,
	linux-kernel@...r.kernel.org,
	Christian Krafft <parabelboi@...serverein.de>
Subject: Re: [RFC PATCH] ipmi: convert OF driver to platform driver

On Thursday 24 February 2011, Grant Likely wrote:
> On Wed, Feb 23, 2011 at 03:37:59PM -0600, Rob Herring wrote:
> > From: Rob Herring <rob.herring@...xeda.com>
> > 
> > of_bus is deprecated in favor of the plain platform bus. This patch
> > merges the ipmi OF driver with the existing platform driver.
> > 
> > CONFIG_PPC_OF occurrances are removed or replaced with CONFIG_OF.
> > 
> > Compile tested with and without CONFIG_OF. Tested OF probe and
> > default probe cases.
> > 
> > Signed-off-by: Rob Herring <rob.herring@...xeda.com>
> 
> Wow.  That driver does some weird things with the driver model that
> really should be cleaned up.  That said, this change looks correct.
> I'll add it to my tree and see how it goes.

Please keep me in the look when you want to do further into cleaning
this up. The OF code was initially done for the QS21 running SLOF, and
predates the flattened device tree specs.

I don't know if Christian still remembers the code, but it might
be worthwhile having him on Cc as well.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/