linux-kernel - Re: [TRIVIAL/PATCH] ARM: hw_breakpoint: Fix newlines in WARN messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1298633466.32588.1.camel@e102144-lin.cambridge.arm.com>
Date:	Fri, 25 Feb 2011 11:31:06 +0000
From:	Will Deacon <will.deacon@....com>
To:	Lothar Waßmann <LW@...O-electronics.de>
Cc:	Stephen Boyd <sboyd@...eaurora.org>, trivial@...nel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [TRIVIAL/PATCH] ARM: hw_breakpoint: Fix newlines in WARN
 messages

On Fri, 2011-02-25 at 06:38 +0000, Lothar Waßmann wrote:
> Hi,
> 
Hello,

> Stephen Boyd writes:
> > These warnings are missing newlines and spaces causing confusing
> > looking output when they trigger.
> >
> > Cc: Will Deacon <will.deacon@....com>
> > Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> > ---
> >  arch/arm/kernel/hw_breakpoint.c |   13 +++++++------
> >  1 files changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
> > index d600bd3..5aab00e 100644
> > --- a/arch/arm/kernel/hw_breakpoint.c
> > +++ b/arch/arm/kernel/hw_breakpoint.c
> > @@ -238,8 +238,8 @@ static int enable_monitor_mode(void)
> >       ARM_DBG_READ(c1, 0, dscr);
> > 
> >       /* Ensure that halting mode is disabled. */
> > -     if (WARN_ONCE(dscr & ARM_DSCR_HDBGEN, "halting debug mode enabled."
> > -                             "Unable to access hardware resources.")) {
> > +     if (WARN_ONCE(dscr & ARM_DSCR_HDBGEN, "halting debug mode enabled. "
> > +                             "Unable to access hardware resources.\n")) {
> >
> I'd prefer the message text not to be line wrapped, even if it
> violates the general line length rule, because that makes it easier to
> grep for the message in the source code.


Ok, that's understandable. Moving the text onto its own line will limit
the damage to the line length too. Stephen - are you happy to make these
changes as part of your previous patch?

Thanks,

Will


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/