linux-kernel - Re: [PATCH] expose kvmclock upper msr set.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1298639488.15736.313.camel@mothafucka.localdomain>
Date:	Fri, 25 Feb 2011 10:11:28 -0300
From:	Glauber Costa <glommer@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org, avi@...hat.com
Subject: Re: [PATCH] expose kvmclock upper msr set.

On Thu, 2011-02-24 at 18:54 -0500, Steven Rostedt wrote:
> On Thu, 2011-02-24 at 20:48 -0300, Glauber Costa wrote:
> > On Thu, 2011-02-24 at 18:24 -0500, Steven Rostedt wrote:
> > > On Wed, Feb 23, 2011 at 12:44:14PM -0500, Glauber Costa wrote:
> > > > We've been supporting kvmclock MSRs in the 0x4b564d00-0x4b564dff range
> > > > for a while now, but we're not exposing it yet, meaning nobody is using it.
> > > > This simple patch takes care of that.
> > > 
> > > Is nobody using it because it was never exposed? Or because nobody ever
> > > needed it, and we don't care (thus don't bother supporting it).
> > > 
> > The former. Our guest kernels will only rely on features that are
> > exposed, meaning that if they are not, the guest kernel will never know
> > it is available. 
> > 
> 
> Might want to rephrase your change log, as to me it sounds like nobody
> is using it because it is not needed. Adding the "Our guest..." from
> your response to the change log will clear that up.
> 
> Thanks,
I can do that, sure.

OTOH, I know avi changed changelogs for clarity a couple of times
before, so if there is no code change needed, maybe he think it is
easier to rephrase it before picking it up.

Avi?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/