linux-kernel - Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Feb 2011 09:14:06 -0600
From:	Chris Bagwell <chris@...bagwell.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Corentin Chary <corentin.chary@...il.com>,
	Keng-Yu Lin <keng-yu.lin@...onical.com>,
	Matthew Garrett <mjg@...hat.com>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	tyson.chen@...onical.com
Subject: Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21

On Fri, Feb 25, 2011 at 1:18 AM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Fri, Feb 25, 2011 at 07:52:11AM +0100, Corentin Chary wrote:
>> On Fri, Feb 25, 2011 at 6:19 AM, Keng-Yu Lin <keng-yu.lin@...onical.com> wrote:
>> > Signed-off-by: Keng-Yu Lin <keng-yu.lin@...onical.com>
>> > ---
>> >  drivers/platform/x86/eeepc-wmi.c |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > https://bugs.freedesktop.org/show_bug.cgi?id=31333
>> >
>> > diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
>> > index d399775..da00cbc 100644
>> > --- a/drivers/platform/x86/eeepc-wmi.c
>> > +++ b/drivers/platform/x86/eeepc-wmi.c
>> > @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = {
>> >        { KE_KEY, 0x32, { KEY_MUTE } },
>> >        { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */
>> >        { KE_KEY, 0x5d, { KEY_WLAN } },
>> > -       { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */
>> > +       { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */
>> >        { KE_KEY, 0x82, { KEY_CAMERA } },
>> >        { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } },
>> >        { KE_KEY, 0x88, { KEY_WLAN } },
>>
>> Hum, I'm not very comfortable with this patch now that we got
>> KEY_TOUCHPAD_TOGGLE.
>> I know, it doesn't work with current Xorg, but if we continue to
>> workaround that, it'll never be fixed.
>>
>> Dmitry, Matthew, any advice ?
>
> I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace
> should use udev's key re-mapping facilities while X is unable to process
> keycodes above 255 to adjust to the keycode du jour. If all kernel
> drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much
> easier (the utility would simply check capabilities for
> KEY_TOUCHPAD_TOGGLE and do the remap).

I submitted last month a patch to udev to do the scancode-to-F21
mapping.  So that part should be covered for near term.

I also agree if we are going to change kernel side, we should change
to KEY_TOUCHPAD_TOGGLE in both eeepc-laptop and eeepc-wmi.

http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=0d8b6be5f5238360d2d8e220d6da280f842c5358

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/