linux-kernel - Re: [RFC PATCH] x86: Moving probe_roms_32 to probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D67DAF2.8090501@intel.com>
Date:	Fri, 25 Feb 2011 08:38:10 -0800
From:	Dan Williams <dan.j.williams@...el.com>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	"Jiang, Dave" <dave.jiang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	David Milburn <dmilburn@...hat.com>
Subject: Re: [RFC PATCH] x86: Moving probe_roms_32 to probe_roms

On 02/25/2011 02:13 AM, Williams, Dan J wrote:
[..]
> +		if (probe_kernel_address(rom + offset + 0x8, list) != 0 &&
> +		    probe_kernel_address(rom + offset + 0xc, rev) != 0 &&

These should be "== 0", but you get the idea...


> +		    rev>= 3&&  list&&
> +		    probe_list(pdev, vendor, rom + offset + list)) {
> +			oprom = res;
> +			break;
> +		}
> +	}

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/