linux-kernel - Re: [PATCH RESEND 1/1] Cleanup of asm-offsets.c(PAGE_SIZE_asm, PAGE_SHIFT_asm, THREAD_SIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Feb 2011 12:20:23 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Stratos Psomadakis <psomas@...ab.ece.ntua.gr>
CC:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH RESEND 1/1] Cleanup of asm-offsets.c(PAGE_SIZE_asm, PAGE_SHIFT_asm,
 THREAD_SIZE_asm)

On 02/25/2011 12:03 PM, Stratos Psomadakis wrote:
> Cleanup of asm-offsets.c.
> 
> PAGE_SIZE_asm, PAGE_SHIFT_asm, THREAD_SIZE_asm can be safely removed from 
> asm-offsets.c, and be replaced by their non-'_asm' counterparts in the code 
> that uses them, since the _AC macro defined in include/linux/const.h makes
> PAGE_SIZE/PAGE_SHIFT/THREAD_SIZE work with as.
> 
> Signed-off-by: Stratos Psomadakis <psomas@...ab.ece.ntua.gr>
> ---
>  arch/mn10300/kernel/asm-offsets.c      |    2 --
>  arch/mn10300/kernel/gdb-io-ttysm-low.S |    2 +-
>  arch/x86/kernel/asm-offsets_32.c       |    4 ----
>  arch/x86/kernel/asm-offsets_64.c       |    1 -
>  arch/x86/kernel/entry_32.S             |    2 +-
>  arch/x86/kernel/head_32.S              |    8 ++++----
>  arch/x86/xen/xen-head.S                |    4 ++--
>  7 files changed, 8 insertions(+), 15 deletions(-)
> 

Looks good, but please separate the mn10300 and x86 chunks into separate
patches.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/