linux-kernel - Re: [PATCH 3/4] PCI: introduce reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110225145621.6f2facc4@jbarnes-desktop>
Date:	Fri, 25 Feb 2011 14:56:21 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Ram Pai <linuxram@...ibm.com>
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	clemens@...isch.de, Yinghai Lu <yinghai@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Bjorn Helgaas <bjorn.helgaas@...com>
Subject: Re: [PATCH 3/4] PCI: introduce reset_resource()

On Mon, 14 Feb 2011 17:43:19 -0800
Ram Pai <linuxram@...ibm.com> wrote:

> introduced reset_resource() which factors out resource reset logic.
> 
>     Signed-off-by: Ram Pai <linuxram@...ibm.com>
> ---
>  drivers/pci/setup-bus.c |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index bcf5752..a94ecc1 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -88,6 +88,13 @@ static void __dev_sort_resources(struct pci_dev *dev,
>  	pdev_sort_resources(dev, head);
>  }
>  
> +static inline void reset_resource(struct resource *res)
> +{
> +	res->start = 0;
> +	res->end = 0;
> +	res->flags = 0;
> +}
> +

Probably belongs in resource.c, and there may be other users that can
be cleaned up as well.  Nice improvement to readability.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/