linux-kernel - RE: [PATCH 6/6] Staging: hv: Cleanup hyperv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6E21E5352C11B742B20C142EB499E048015773@TK5EX14MBXC128.redmond.corp.microsoft.com>
Date:	Sat, 26 Feb 2011 17:13:22 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Dan Carpenter <error27@...il.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>
Subject: RE: [PATCH 6/6] Staging: hv: Cleanup hyperv_driver variable names



> -----Original Message-----
> From: Dan Carpenter [mailto:error27@...il.com]
> Sent: Friday, February 25, 2011 10:41 PM
> To: KY Srinivasan
> Cc: gregkh@...e.de; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; virtualization@...ts.osdl.org
> Subject: Re: [PATCH 6/6] Staging: hv: Cleanup hyperv_driver variable names
> 
> On Fri, Feb 25, 2011 at 06:07:58PM -0800, K. Y. Srinivasan wrote:
> > The title says it all.
> >
> 
> For this patch the rename_rev.pl command is:
> 
> rename_rev.pl -nc -e 's/(drv|driver)_ctx/drv/g'
> 
> > --- a/drivers/staging/hv/vmbus_drv.c
> > +++ b/drivers/staging/hv/vmbus_drv.c
> > @@ -46,7 +46,7 @@ struct vmbus_hyperv_driver {
> >  	/* FIXME, this is a bug */
> >  	/* The driver field is not used in here. Instead, the bus field is */
> >  	/* used to represent the driver */
>         ^^
> This comment out of date now that we're using container_of().
This requirement is for a different reason. We had patch out last Wednesday
To address this but was rejected by Greg for other reasons.
What is happening here is that in the vmbus_match function we 
need to get at a certain field in a driver agnostic way. This hack solves
the problem. It will be removed once this series goes in.

> 
> > -	struct hyperv_driver drv_ctx;
> > +	struct hyperv_driver dummy;
>                              ^^^^^
> Delete.

This is the hack I talked about earlier. This will go away
once this series goes in.

> 
> > @@ -849,18 +849,18 @@ static int vmbus_uevent(struct device *device, struct
> kobj_uevent_env *env)
> >  static int vmbus_match(struct device *device, struct device_driver *driver)
> >  {
> >  	int match = 0;
> > -	struct hyperv_driver *driver_ctx = driver_to_hyperv_driver(driver);
> > +	struct hyperv_driver *drv = driver_to_hyperv_driver(driver);
> >  	struct hyperv_device *device_obj = device_to_hyperv_device(device);
> >
> >  	/* We found our driver ? */
> > -	if (memcmp(&device_obj->class_id, &driver_ctx->class_id,
> > +	if (memcmp(&device_obj->class_id, &drv->class_id,
> >  		   sizeof(struct hv_guid)) == 0) {
> >  		/*
> > -		 * !! NOTE: The driver_ctx is not a vmbus_drv_ctx. We typecast
> > +		 * !! NOTE: The drv is not a vmbus_drv_ctx. We typecast
>                                                       ^^^^
> Out of date.
This hack is still required. We will get rid of this shortly.

Regards,

K. Y
> 
> regards,
> dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/