linux-kernel - Re: TX VLAN acceleration on bridges broken in 2.6.37?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110226001908.GA10777@x61s.reliablesolutions.de>
Date:	Sat, 26 Feb 2011 01:19:08 +0100
From:	Jan Niehusmann <jan@...dor.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: TX VLAN acceleration on bridges broken in 2.6.37?

On Fri, Feb 25, 2011 at 02:53:21PM -0800, Jesse Gross wrote:
> is specific to the e1000e driver.  I know that some other Intel NICs
> require vlan stripping on receive to be enabled for vlan insertion on
> transmit to work.  Since this driver has not been converted over to
> use the new vlan model yet, it only enables these things if a vlan is
> directly configured on it.  To confirm this can you try a few things:

My observations confirm your theory:

> * Directly configure the vlan on the device instead of going through the bridge.

- does work, but only if eth0 is not part of bridge (expected behaviour,
  afaik)

> * Use the bridge but also configure an unused vlan device on the
> physical interface.

- does work

> * Double check that tcpdump with the settings that you are using shows
> vlan tags in other situations.  In some cases you need to use the 'e'
> flag with tcpdump in order for it show vlan tags.  If it is the
> driver/NIC that is dropping the tags, tcpdump should still show them.

- indeed, -e is necessary to show the vlan tags. So my prior observation
  regarding tag visibility in tcpdump was wrong. The packets are still
  have a vlan tag in the non-working case. 

  (What actually is affected by the txvlan flag is the ability to filter
  for vlan tags with tcpdump.  so 'tcpdump -e -i eth0' shows the packets,
  'tcpdump -e -i eth0 vlan' only shows them with txvlan off. However,
  filtering for the vlan tag also doesn't work with the vlan interface
  on eth0.1, while the tagging actually works, as verified above.)

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/