linux-kernel - Re: [PATCH v2] tpm_tis: Use timeouts returned from TPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D68E7CA.60704@gmail.com>
Date:	Sat, 26 Feb 2011 12:45:14 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Stefan Berger <stefanb@...ux.vnet.ibm.com>
CC:	preining@...ic.at,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>,
	"debora@...ux.vnet.ibm.com" <debora@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2] tpm_tis: Use timeouts returned from TPM

On 02/22/2011 08:41 PM, Stefan Berger wrote:
> Below patch applies to the tip of the git tree.
> 
> v2:
>   - adjusting all timeouts for TPM devices reporting too low timeout
> numbers
>   - also displaying in sysfs whether the timeouts are 'original' or
> 'adjusted'
> 
> The current TPM TIS driver in git discards the timeout values returned
> from the TPM. The check of the response packet needs to consider that
> the return_code field is 0 on success and the size of the expected
> packet is equivalent to the header size + u32 length indicator for the
> TPM_GetCapability() result + 3 timeout indicators of type u32.
> 
> Since some TPMs seem to return timeouts in msec rather than usec,
> I am now adjusting all the timeouts rather than just the one for short
> durations.
> 
> I am also adding a sysfs entry 'timeouts' showing the timeouts that are
> being used.

It works:
# dmesg
[15318.813905] tpm_tis 00:0c: 1.2 TPM (device-id 0xB, rev-id 16)
[15318.879154] tpm_tis 00:0c: Adjusting TPM timeout parameters.
# cat /sys/devices/pnp0/00\:0*/timeouts
1000000 2000000 150000000 [adjusted]

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/