linux-kernel - Re: [PATCH 09/12] unicore32 machine related files: hardware registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201102271815.42395.arnd@arndb.de>
Date:	Sun, 27 Feb 2011 18:15:42 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	"Guan Xuetao" <gxt@...c.pku.edu.cn>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	"'Greg KH'" <greg@...ah.com>
Subject: Re: [PATCH 09/12] unicore32 machine related files: hardware registers

On Sunday 27 February 2011, Guan Xuetao wrote:
> Please see following patch, __REG removed and __iomem added to io_p2v:
> 
> diff --git a/arch/unicore32/include/mach/hardware.h b/arch/unicore32/include/mach/hardware.h
> index b71405a..b197b0b 100644
> --- a/arch/unicore32/include/mach/hardware.h
> +++ b/arch/unicore32/include/mach/hardware.h
> @@ -17,13 +17,10 @@
>  
>  #include "PKUnity.h"
>  
> -#define io_p2v(x)      ((x) - PKUNITY_MMIO_BASE)
> -#define io_v2p(x)      ((x) + PKUNITY_MMIO_BASE)
> -
>  #ifndef __ASSEMBLY__
> -
> -# define __REG(x)      (void __iomem *)io_p2v(x)
> -
> +#define io_p2v(x)      (void __iomem *)((x) - PKUNITY_MMIO_BASE)
> +#else
> +#define io_p2v(x)      ((x) - PKUNITY_MMIO_BASE)
>  #endif
>  
>  #define PCIBIOS_MIN_IO                 0x4000 /* should lower than 64KB */

Yes, looks good!

Acked-by: Arnd Bergmann <arnd@...db.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/