linux-kernel - Re: [PATCH RESEND v2] i2c-eg20t: support new device OKI SEMICONDUCTOR ML7213 IOH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110228115225.GB9075@bicker>
Date:	Mon, 28 Feb 2011 14:52:25 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>
Cc:	Jean Delvare <khali@...ux-fr.org>, Ben Dooks <ben-linux@...ff.org>,
	Seth Heasley <seth.heasley@...el.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	qi.wang@...el.com, yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com, toshiharu-linux@....okisemi.com
Subject: Re: [PATCH RESEND v2] i2c-eg20t: support new device OKI
 SEMICONDUCTOR ML7213 IOH

On Mon, Feb 28, 2011 at 03:54:32PM +0900, Tomoya MORINAGA wrote:
> -	ret = i2c_add_adapter(&(adap_info->pch_data.pch_adapter));
> +		pch_adap->dev.parent = &pdev->dev;
>  
> -	if (ret) {
> -		pch_pci_err(pdev, "i2c_add_adapter FAILED\n");
> -		goto err_i2c_add_adapter;
> -	}
> +		ret = i2c_add_adapter(pch_adap);
> +		if (ret) {
> +			pch_pci_err(pdev, "i2c_add_adapter[ch:%d] FAILED\n", i);
> +			goto err_i2c_add_adapter;

I think goto err_request_irq was intended here.  On a side note, it's
always better to name goto destinations after the destination instead
of the starting point.  In this case, we have two gotos to one
destination and the label err_request_irq makes no sense.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/