linux-kernel - Re: [PATCH] rtlwifi: fix places where uninitialized data is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D6BEA16.2060604@lwfinger.net>
Date:	Mon, 28 Feb 2011 12:31:50 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Alessio Igor Bogani <abogani@...nel.org>,
	John Linville <linville@...driver.com>
CC:	Dan Carpenter <error27@...il.com>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	linux-wireless@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Tim Bird <tim.bird@...sony.com>
Subject: Re: [PATCH] rtlwifi: fix places where uninitialized data is used

On 02/28/2011 02:11 AM, Alessio Igor Bogani wrote:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function
>
> This work was supported by a hardware donation from the CE Linux Forum.
>
> Signed-off-by: Alessio Igor Bogani<abogani@...nel.org>
> ---
>   drivers/net/wireless/rtlwifi/rtl8192ce/trx.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> index bf5852f..593eb8e 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> @@ -252,9 +252,9 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
>   	struct rtl_priv *rtlpriv = rtl_priv(hw);
>   	struct phy_sts_cck_8192s_t *cck_buf;
>   	s8 rx_pwr_all, rx_pwr[4];
> -	u8 rf_rx_num, evm, pwdb_all;
> +	u8 evm, pwdb_all, rf_rx_num = 0;
>   	u8 i, max_spatial_stream;
> -	u32 rssi, total_rssi;
> +	u32 rssi, total_rssi = 0;
>   	bool is_cck_rate;
>
>   	is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc);
> @@ -463,7 +463,7 @@ static void _rtl92ce_update_rxsignalstatistics(struct ieee80211_hw *hw,
>   					       struct rtl_stats *pstats)
>   {
>   	struct rtl_priv *rtlpriv = rtl_priv(hw);
> -	int weighting;
> +	int weighting = 0;
>
>   	if (rtlpriv->stats.recv_signal_power == 0)
>   		rtlpriv->stats.recv_signal_power = pstats->recvsignalpower;

ACK. Obviously gcc 4.5.1 has a bug and misses these, whereas 4.5.2 finds them.

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/