linux-kernel - Re: 2.6.38 regression caused by commit 415e12b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201102282129.56835.rjw@sisk.pl>
Date:	Mon, 28 Feb 2011 21:29:56 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Cc:	linux-usb@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Ozan Caglayan <ozan@...dus.org.tr>
Subject: Re: 2.6.38 regression caused by commit 415e12b

On Monday, February 28, 2011, Sarah Sharp wrote:
> I'm having an issue with an xHCI (USB 3.0 host controller) Express Card.
> This card works fine on 2.6.37, but on 2.6.38-rc5, when I plug in the
> card, I get this output in dmesg:
> 
> Feb 22 16:32:28 xanatos kernel: [  119.345996] irq 23: nobody cared (try booting with the "irqpoll" option)
> Feb 22 16:32:28 xanatos kernel: [  119.346002] Pid: 0, comm: kworker/0:0 Not tainted 2.6.38-rc5+ #745
> Feb 22 16:32:28 xanatos kernel: [  119.346005] Call Trace:
> Feb 22 16:32:28 xanatos kernel: [  119.346007]  <IRQ>  [<ffffffff8109a1f6>] ? __report_bad_irq+0x26/0xa0
> Feb 22 16:32:28 xanatos kernel: [  119.346019]  [<ffffffff8109a3fc>] ? note_interrupt+0x18c/0x1d0
> Feb 22 16:32:28 xanatos kernel: [  119.346024]  [<ffffffff8109ad7d>] ? handle_fasteoi_irq+0xcd/0x100
> Feb 22 16:32:28 xanatos kernel: [  119.346029]  [<ffffffff8100543d>] ? handle_irq+0x1d/0x30
> Feb 22 16:32:28 xanatos kernel: [  119.346032]  [<ffffffff81004bb8>] ? do_IRQ+0x58/0xd0
> Feb 22 16:32:28 xanatos kernel: [  119.346037]  [<ffffffff8149f5d3>] ? ret_from_intr+0x0/0xe
> Feb 22 16:32:28 xanatos kernel: [  119.346040]  <EOI>  [<ffffffff8126f2d0>] ? acpi_idle_enter_c1+0x7e/0x99
> Feb 22 16:32:28 xanatos kernel: [  119.346048]  [<ffffffff8126f2b2>] ? acpi_idle_enter_c1+0x60/0x99
> Feb 22 16:32:28 xanatos kernel: [  119.346054]  [<ffffffff8138ac92>] ? cpuidle_idle_call+0x82/0xf0
> Feb 22 16:32:28 xanatos kernel: [  119.346059]  [<ffffffff81001906>] ? cpu_idle+0x56/0xb0
> Feb 22 16:32:28 xanatos kernel: [  119.346064]  [<ffffffff8149861b>] ? start_secondary+0x1c1/0x1c8
> Feb 22 16:32:28 xanatos kernel: [  119.346068]  [<ffffffff81263386>] ? acpi_ns_parse_table+0x2e/0x34
> Feb 22 16:32:28 xanatos kernel: [  119.346073]  [<ffffffff81267a8c>] ? acpi_load_tables+0x9c/0x15d
> Feb 22 16:32:28 xanatos kernel: [  119.346076] handlers:
> Feb 22 16:32:28 xanatos kernel: [  119.346078] [<ffffffffa0123500>] (usb_hcd_irq+0x0/0x70 [usbcore])
> Feb 22 16:32:28 xanatos kernel: [  119.346100] Disabling IRQ #23
> 
> This happens before the xHCI driver has a chance to start PCI
> initialization.
> 
> I've been trying to bisect this on a slow laptop, so I haven't had a
> chance to test with the latest tree from Linus to see if this is already
> fixed.  I'll do that later this evening.
> 
> I've bisected the issue down to this commit:
> 
> 415e12b2379239973feab91850b0dce985c6058a is first bad commit
> commit 415e12b2379239973feab91850b0dce985c6058a
> Author: Rafael J. Wysocki <rjw@...k.pl>
> Date:   Fri Jan 7 00:55:09 2011 +0100
> 
>     PCI/ACPI: Request _OSC control once for each root bridge (v3)
>     
>     Move the evaluation of acpi_pci_osc_control_set() (to request control of
>     PCI Express native features) into acpi_pci_root_add() to avoid calling
>     it many times for the same root complex with the same arguments.
>     Additionally, check if all of the requisite _OSC support bits are set
>     before calling acpi_pci_osc_control_set() for a given root complex.
>     
>     References: https://bugzilla.kernel.org/show_bug.cgi?id=20232
>     Reported-by: Ozan Caglayan <ozan@...dus.org.tr>
>     Tested-by: Ozan Caglayan <ozan@...dus.org.tr>
>     Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
>     Signed-off-by: Jesse Barnes <jbarnes@...tuousgeek.org>
> 
> :040000 040000 531c48ec0c23b72f0ca1b5f33828ea63808e4033 7ffa298e34dd842e1f84f0b1fea6dc5af1f70514 M	drivers
> :040000 040000 4e484ec0cab0ebc7c82a029c4860802617b7aaf2 01b429bcaeb7b50af04667664cf25453058e803f M	include
> 
> lspci from a kernel where the Express Card works is attached.

Most likely your card requires PCIe hotplug to work which doesn't with the
above commit applied due to some dependencies that aren't met.

May I see full dmesg output with and without the above commit?

It may be more convenient to add a Bugzilla entry for it.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/