linux-kernel - Re: [PATCH v2 02/13] da850: pruss platform specific additions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4102429DCB2B4B47A4F51ED0B9A62E2B@subhasishg>
Date:	Tue, 1 Mar 2011 12:29:28 +0530
From:	"Subhasish Ghosh" <subhasish@...tralsolutions.com>
To:	"TK, Pratheesh Gangadhar" <pratheesh@...com>,
	<davinci-linux-open-source@...ux.davincidsp.com>
Cc:	<sachi@...tralsolutions.com>,
	"Russell King" <linux@....linux.org.uk>,
	"Kevin Hilman" <khilman@...prootsystems.com>,
	"open list" <linux-kernel@...r.kernel.org>,
	"Watkins, Melissa" <m-watkins@...com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 02/13] da850: pruss platform specific additions.

Hello,

Can we not have the PRU UIO also as a part of the MFD framework.
I know that the UIO is not really a device, but I feel its incorrect to 
register the same device twice.
Instead we can have a single entry as the MFD framework and the UIO, as a 
child device, based upon the MFD driver APIs.

All that we need to do is add an entry into the da8xx_pruss_devices 
structure
and the MFD driver will do the rest to get the UIO probe called.

--------------------------------------------------
From: "TK, Pratheesh Gangadhar" <pratheesh@...com>
Sent: Monday, February 28, 2011 6:34 PM
To: "Subhasish Ghosh" <subhasish@...tralsolutions.com>; 
<davinci-linux-open-source@...ux.davincidsp.com>
Cc: <sachi@...tralsolutions.com>; "Russell King" <linux@....linux.org.uk>; 
"Kevin Hilman" <khilman@...prootsystems.com>; "open list" 
<linux-kernel@...r.kernel.org>; "Watkins, Melissa" <m-watkins@...com>; 
<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 02/13] da850: pruss platform specific additions.

> Hi,
>
>> -----Original Message-----
>> From: davinci-linux-open-source-bounces@...ux.davincidsp.com
>> [mailto:davinci-linux-open-source-bounces@...ux.davincidsp.com] On Behalf
>> Of Subhasish Ghosh
>> Sent: Friday, February 11, 2011 8:21 PM
>> To: davinci-linux-open-source@...ux.davincidsp.com
>> Cc: sachi@...tralsolutions.com; Russell King; Kevin Hilman; Subhasish
>> Ghosh; open list; Watkins, Melissa; linux-arm-kernel@...ts.infradead.org
>> Subject: [PATCH v2 02/13] da850: pruss platform specific additions.
>>
>> This patch adds the platform device and assignes the platform resources
>> for the PRUSS mfd driver.
>>
>> Signed-off-by: Subhasish Ghosh <subhasish@...tralsolutions.com>
>> ---
>> +struct platform_device da8xx_pruss_dev = {
> Can you please rename this to da8xx_pruss_mfddev?
>> + .name = "da8xx_pruss",
> Can you please rename name string as pruss_mfd? This will help to
> base my UIO patches on top of yours.
>> + .id = -1,
>> + .num_resources = ARRAY_SIZE(da8xx_pruss_resources),
>> + .resource = da8xx_pruss_resources,
>> +};
>> +
>> +int __init da8xx_register_pruss(struct da8xx_pruss_devices 
>> *pruss_device)
> Please rename this to da8xx_register_pruss_mfd
>
> Thanks,
> Pratheesh 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/