linux-kernel - Re: [PATCH 1/1] staging: vme: remove unreachable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D6D122B.5050404@ge.com>
Date:	Tue, 01 Mar 2011 15:35:07 +0000
From:	Martyn Welch <martyn.welch@...com>
To:	Manohar Vanga <manohar.vanga@...n.ch>
CC:	gregkh@...e.de, julia@...u.dk, cota@...ap.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: vme: remove unreachable code

On 26/02/11 23:15, Manohar Vanga wrote:
> Remove some more unreachable code found in bridges/vme_ca91cx42.c
> and bridges/vme_tsi148.c
> 
> Signed-off-by: Manohar Vanga <manohar.vanga@...n.ch>

Acked-by Martyn Welch <martyn.welch@...com>

> ---
>  drivers/staging/vme/bridges/vme_ca91cx42.c |    3 ---
>  drivers/staging/vme/bridges/vme_tsi148.c   |    2 --
>  2 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
> index 42de83e..5d734d9 100644
> --- a/drivers/staging/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
> @@ -560,8 +560,6 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
>  
>  	return 0;
>  
> -	iounmap(image->kern_base);
> -	image->kern_base = NULL;
>  err_remap:
>  	release_resource(&image->bus_resource);
>  err_resource:
> @@ -1782,7 +1780,6 @@ static int ca91cx42_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  
>  	return 0;
>  
> -	vme_unregister_bridge(ca91cx42_bridge);
>  err_reg:
>  	ca91cx42_crcsr_exit(ca91cx42_bridge, pdev);
>  err_lm:
> diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
> index 26ea42f..2df19ea 100644
> --- a/drivers/staging/vme/bridges/vme_tsi148.c
> +++ b/drivers/staging/vme/bridges/vme_tsi148.c
> @@ -869,8 +869,6 @@ static int tsi148_alloc_resource(struct vme_master_resource *image,
>  
>  	return 0;
>  
> -	iounmap(image->kern_base);
> -	image->kern_base = NULL;
>  err_remap:
>  	release_resource(&image->bus_resource);
>  err_resource:


-- 
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms                   | Wales (3828642) at 100
T +44(0)127322748                          | Barbirolli Square, Manchester,
E martyn.welch@...com                      | M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/