linux-kernel - Re: RFC: [PATCH 0/5] staging: sep: Enable kernel crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110301212350.GA22953@kroah.com>
Date:	Tue, 1 Mar 2011 16:23:50 -0500
From:	Greg KH <greg@...ah.com>
To:	"Allyn, Mark A" <mark.a.allyn@...el.com>
Cc:	"Mangalampalli, Jayant" <jayant.mangalampalli@...el.com>,
	"Gokulrangan, Venkat R" <venkat.r.gokulrangan@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>
Subject: Re: RFC: [PATCH 0/5] staging: sep: Enable kernel crypto

On Tue, Mar 01, 2011 at 02:10:09PM -0700, Allyn, Mark A wrote:
> Greg writes:
> 
> Why?  What does this mean to me?  To users?  You need to sell this new
> feature to me a LOT before I will take it as I really want and need to
> see this driver fixed up first before you can add new features to it.
> 
> thanks,
> 
> greg k-h
> 
> 
> =================
> 
> Greg:
> 
> I agree; I will work on getting the current core driver out of staging prior to making the kernel crypto changes.

First off, please fix your email client to do proper quoting and wrap
lines at 72 columns.  Even Outlook can do this so there really is no
excuse anymore...

> 
> What are the major issues with the core driver? I know about the current items in the TODO list having to do with the unused ioctl calls and structures.
> 
> What other issues are there?

That's a good place to start, fix those up and when you feel you have
addressed everything, ask for a review of the code and we can go from
there.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/