linux-kernel - Re: [PATCH 5/6] Staging: hv: Rename driver_context to hyperv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110301025640.GF1663@kroah.com>
Date:	Mon, 28 Feb 2011 18:56:40 -0800
From:	Greg KH <greg@...ah.com>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, virtualization@...ts.osdl.org,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Hank Janssen <hjanssen@...rosoft.com>
Subject: Re: [PATCH 5/6] Staging: hv:  Rename driver_context to
 hyperv_driver

On Fri, Feb 25, 2011 at 06:07:38PM -0800, K. Y. Srinivasan wrote:
> The title says it all.

No it doesn't.  You should have done this on the last patch to keep me
from complaining about that name.

Oh, and the extra space, drop it please.

> --- a/drivers/staging/hv/blkvsc_drv.c
> +++ b/drivers/staging/hv/blkvsc_drv.c
> @@ -116,10 +116,10 @@ struct block_device_context {
>  };
>  
>  /* Per driver */
> -struct blkvsc_driver_context {
> +struct blkvsc_hyperv_driver {
>  	/* !! These must be the first 2 fields !! */
>  	/* FIXME this is a bug! */
> -	struct driver_context drv_ctx;
> +	struct hyperv_driver drv_ctx;
>  	struct storvsc_driver_object drv_obj;
>  };
>  

Hey look, that Subject: and changelog body actually lied.  It didn't say
it all.  In fact, it didn't say enough, or you just renamed a different
structure because it felt nice.

{sigh}

One thing per patch, with full description.  I'm getting tired of
repeating Documentation/CodingStyle for this subsystem when patches are
submitted.

It's as if no one even listens to me...

{sniff}

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/