linux-kernel - Re: [PATCH 1/6] Staging: hv: Unify hyper-v device abstractions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2011 09:35:02 +0300
From:	Dan Carpenter <error27@...il.com>
To:	KY Srinivasan <kys@...rosoft.com>
Cc:	Greg KH <greg@...ah.com>, "gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>
Subject: Re: [PATCH 1/6] Staging: hv: Unify hyper-v device abstractions

The problem is that everyone reading [patch 1/6] thinks you're renaming
hv_device to vm_device or introducing a new struct vm_device.  That
makes people annoyed.  If you had written the patch description like this:

    In the original code, the structs vm_device included a struct
    hv_device.  This patch moves the members from hv_device directly
    into struct vm_device.

    The members ->dev_type and ->dev_instance from hv_device were
    the same as ->class_id and ->device_id in vm_device so those
    were not copied over.

    Now that everything is included into vm_device directly, 
    hv_device is unused and we can delete the definition.

There still might be issues with the patch, but at least you would be
talking about the same thing.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/