linux-kernel - Re: [PATCH] perf_events: update PEBS event constraints (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110302081430.GE15665@elte.hu>
Date:	Wed, 2 Mar 2011 09:14:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	Lin Ming <ming.m.lin@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"paulus@...ba.org" <paulus@...ba.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"fweisbec@...il.com" <fweisbec@...il.com>,
	"perfmon2-devel@...ts.sf.net" <perfmon2-devel@...ts.sf.net>,
	"eranian@...il.com" <eranian@...il.com>,
	"robert.richter@....com" <robert.richter@....com>,
	"acme@...hat.com" <acme@...hat.com>
Subject: Re: [PATCH] perf_events: update PEBS event constraints (v2)


* Stephane Eranian <eranian@...gle.com> wrote:

> On Wed, Mar 2, 2011 at 1:56 AM, Lin Ming <ming.m.lin@...el.com> wrote:
> > On Wed, 2011-03-02 at 04:20 +0800, Stephane Eranian wrote:
> >> This patch updates PEBS event constraints for Intel Atom, Nehalem, Westmere.
> >>
> >> This patch also reorganizes the PEBS format/constraint detection code. It is
> >> now based on processor model and not PEBS format. Two processors may use the
> >> same PEBS format without have the same list of PEBS events.
> >>
> >> In this second version, we simplified the initialization of the PEBS constraints
> >> by leveraging the existing switch() statement in perf_event_intel.c. We also
> >> renamed the constraint tables to be more consistent with regular constraints.
> >
> > Hi, Stephane
> >
> > Nice updates.
> > Wondering where did you get these PEBS event constraints? I didn't find
> > these in the latest manual.
> >
> Yeah, the manual is lacking some information. The other source of information
> is the PTU event files (whatif.intel.com).

Plus i suspect you have performed testing on affected CPUs as well?

If yes then i think we want to push these fixes via perf/urgent - they seem to 
nicely round up the constraints.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/