linux-kernel - Re: [tip:x86/mm] x86: Work around old gas bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110302104144.GB25608@elte.hu>
Date:	Wed, 2 Mar 2011 11:41:44 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jan Beulich <JBeulich@...ell.com>
Cc:	shaohua.li@...el.com, tglx@...utronix.de,
	akpm@...ux-foundation.org, mingo@...hat.com,
	linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [tip:x86/mm] x86: Work around old gas bug


* Jan Beulich <JBeulich@...ell.com> wrote:

> >>> On 02.03.11 at 09:42, tip-bot for Shaohua Li <shaohua.li@...el.com> wrote:
> > Commit-ID:  253d89d3dd6b65595f317e5f1ecef43aa207a3a0
> > Gitweb:     
> > http://git.kernel.org/tip/253d89d3dd6b65595f317e5f1ecef43aa207a3a0 
> > Author:     Shaohua Li <shaohua.li@...el.com>
> > AuthorDate: Tue, 1 Mar 2011 15:52:26 -0800
> > Committer:  Ingo Molnar <mingo@...e.hu>
> > CommitDate: Wed, 2 Mar 2011 08:16:23 +0100
> > 
> > x86: Work around old gas bug
> > 
> > pre-2.16 binutils works fine, post-2.16 binutils works fine, but 2.16 broke 
> > again:
> > 
> >  > arch/x86/kernel/entry_64.S: Assembler messages:
> >  > arch/x86/kernel/entry_64.S:984: Error: junk at end of line, first 
> > unrecognized character is `1'
> >  > [...]
> > 
> > Signed-off-by: Shaohua Li <shaohua.li@...el.com>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: "H. Peter Anvin" <hpa@...or.com>
> > Cc: Jan Beulich <jbeulich@...ell.com>
> > LKML-Reference: <201103012352.p21NqRN1006974@...p1.linux-foundation.org>
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> Ingo, didn't you write yesterday that this looks unacceptable to you?

Yes, and we can push this to Linus only once that's been resolved. I trust you to 
queue up the real solution or come up with good reasons why that is not possible for 
GAS 2.16. (at which point we'll just have to live with the ugliness, up to the point 
we decide to deprecate binutils 2.16.)

Meanwhile, what i hate more than ugly code repetition is code that does not build at 
all on akpm's test environment ;-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/