linux-kernel - MS_SILENT vs. vfat and hfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110302114517.GA496@nb.net.home>
Date:	Wed, 2 Mar 2011 12:45:17 +0100
From:	Karel Zak <kzak@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	t.artem@...lcity.com, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Roman Zippel <zippel@...ux-m68k.org>
Subject: MS_SILENT vs. vfat and hfs

 The mount(8) command uses "quiet" mount option as a synonym to the
 MS_SILENT mount flag (since util-linux 2.7, Aug 1997).

 It means than on systems where is properly defined the MS_SILENT
 mount flags in headers is the "quiet" mount option always translated
 to the MS_SILENT mount flags and "quiet" string is never send to FS
 drivers.

   $ strace -e mount mount -o quiet /dev/sdb1 /mnt/test
   mount("/dev/sdb1", "/mnt/test", "vfat", MS_MGC_VAL|MS_SILENT, NULL) = 0
                                                      ^^^^^^^^^

 Unfortunately, 

   $ grep -r \"quiet\" *

   fat/inode.c:    {Opt_quiet, "quiet"},
   hfs/super.c:    { opt_quiet, "quiet" },

 vfat and hfs drivers use "quiet" as a mount option. That's bug.

 There should not be a collision between mount(8) mount options and
 filesystem specific mount options.

 My suggestion is to fix the fat and hfs code to use something other
 than "quiet" (shutup, noisless, ...). I think you don't have to care
 about backward compatibility, because it's probably broken for years.

    Karel

-- 
 Karel Zak  <kzak@...hat.com>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/